feat: prompt user on host key verification (#943)

2025-10-20 09:31:20 +08:00
parent 8cbb48ed67
commit 5272324be6
38 changed files with 1076 additions and 219 deletions
--- a/lib/view/page/server/connection_stats.dart
+++ b/lib/view/page/server/connection_stats.dart
@@ -41,11 +41,7 @@ class _ConnectionStatsPageState extends State<ConnectionStatsPage> {
      appBar: CustomAppBar(
        title: Text(l10n.connectionStats),
        actions: [
-          IconButton(
-            onPressed: _loadStats,
-            icon: const Icon(Icons.refresh),
-            tooltip: libL10n.refresh,
-          ),
+          IconButton(onPressed: _loadStats, icon: const Icon(Icons.refresh), tooltip: libL10n.refresh),
          IconButton(
            onPressed: _showClearAllDialog,
            icon: const Icon(Icons.clear_all, color: Colors.red),
@@ -75,140 +71,90 @@ class _ConnectionStatsPageState extends State<ConnectionStatsPage> {
  }

  Widget _buildServerStatsCard(ServerConnectionStats stats) {
-    final successRate = stats.totalAttempts == 0
-        ? 'N/A'
-        : '${(stats.successRate * 100).toStringAsFixed(1)}%';
+    final successRate = stats.totalAttempts == 0 ? 'N/A' : '${(stats.successRate * 100).toStringAsFixed(1)}%';
    final lastSuccessTime = stats.lastSuccessTime;
    final lastFailureTime = stats.lastFailureTime;

-    return Card(
-      margin: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
-      child: Padding(
-        padding: const EdgeInsets.all(16),
-        child: Column(
-          crossAxisAlignment: CrossAxisAlignment.start,
-          children: [
-            Row(
-              children: [
-                Expanded(
-                  child: Text(
-                    stats.serverName,
-                    style: const TextStyle(
-                      fontSize: 18,
-                      fontWeight: FontWeight.bold,
-                    ),
-                  ),
+    return Padding(
+      padding: const EdgeInsets.all(16),
+      child: Column(
+        crossAxisAlignment: CrossAxisAlignment.start,
+        children: [
+          Row(
+            children: [
+              Expanded(
+                child: Text(
+                  stats.serverName,
+                  style: const TextStyle(fontSize: 18, fontWeight: FontWeight.bold),
                ),
-                Text(
-                  '${libL10n.success}: $successRate',
-                  style: TextStyle(
-                    fontSize: 16,
-                    color: stats.successRate >= 0.8
-                        ? Colors.green
-                        : stats.successRate >= 0.5
-                        ? Colors.orange
-                        : Colors.red,
-                    fontWeight: FontWeight.bold,
-                  ),
-                ),
-              ],
-            ),
-            const SizedBox(height: 12),
-            Row(
-              mainAxisAlignment: MainAxisAlignment.spaceAround,
-              children: [
-                _buildStatItem(
-                  l10n.totalAttempts,
-                  stats.totalAttempts.toString(),
-                  Icons.all_inclusive,
-                ),
-                _buildStatItem(
-                  libL10n.success,
-                  stats.successCount.toString(),
-                  Icons.check_circle,
-                  Colors.green,
-                ),
-                _buildStatItem(
-                  libL10n.fail,
-                  stats.failureCount.toString(),
-                  Icons.error,
-                  Colors.red,
-                ),
-              ],
-            ),
-            if (lastSuccessTime != null || lastFailureTime != null) ...[
-              const SizedBox(height: 16),
-              const Divider(),
-              const SizedBox(height: 8),
-              if (lastSuccessTime != null)
-                _buildTimeItem(
-                  l10n.lastSuccess,
-                  lastSuccessTime,
-                  Icons.check_circle,
-                  Colors.green,
-                ),
-              if (lastFailureTime != null)
-                _buildTimeItem(
-                  l10n.lastFailure,
-                  lastFailureTime,
-                  Icons.error,
-                  Colors.red,
+              ),
+              Text(
+                '${libL10n.success}: $successRate',
+                style: TextStyle(
+                  fontSize: 16,
+                  color: stats.successRate >= 0.8
+                      ? Colors.green
+                      : stats.successRate >= 0.5
+                      ? Colors.orange
+                      : Colors.red,
+                  fontWeight: FontWeight.bold,
                ),
+              ),
            ],
+          ),
+          const SizedBox(height: 12),
+          Row(
+            mainAxisAlignment: MainAxisAlignment.spaceAround,
+            children: [
+              _buildStatItem(l10n.totalAttempts, stats.totalAttempts.toString(), Icons.all_inclusive),
+              _buildStatItem(
+                libL10n.success,
+                stats.successCount.toString(),
+                Icons.check_circle,
+                Colors.green,
+              ),
+              _buildStatItem(libL10n.fail, stats.failureCount.toString(), Icons.error, Colors.red),
+            ],
+          ),
+          if (lastSuccessTime != null || lastFailureTime != null) ...[
            const SizedBox(height: 16),
-            Row(
-              mainAxisAlignment: MainAxisAlignment.spaceBetween,
-              children: [
-                Text(
-                  l10n.recentConnections,
-                  style: const TextStyle(
-                    fontSize: 14,
-                    fontWeight: FontWeight.bold,
-                  ),
-                ),
-                TextButton(
-                  onPressed: () => _showServerDetailsDialog(stats),
-                  child: Text(l10n.viewDetails),
-                ),
-              ],
-            ),
+            const Divider(),
            const SizedBox(height: 8),
-            ...stats.recentConnections.take(3).map(_buildConnectionItem),
+            if (lastSuccessTime != null)
+              _buildTimeItem(l10n.lastSuccess, lastSuccessTime, Icons.check_circle, Colors.green),
+            if (lastFailureTime != null)
+              _buildTimeItem(l10n.lastFailure, lastFailureTime, Icons.error, Colors.red),
          ],
-        ),
+          const SizedBox(height: 16),
+          Row(
+            mainAxisAlignment: MainAxisAlignment.spaceBetween,
+            children: [
+              Text(l10n.recentConnections, style: const TextStyle(fontSize: 14, fontWeight: FontWeight.bold)),
+              TextButton(onPressed: () => _showServerDetailsDialog(stats), child: Text(l10n.viewDetails)),
+            ],
+          ),
+          const SizedBox(height: 8),
+          ...stats.recentConnections.take(3).map(_buildConnectionItem),
+        ],
      ),
-    );
+    ).cardx;
  }

-  Widget _buildStatItem(
-    String label,
-    String value,
-    IconData icon, [
-    Color? color,
-  ]) {
+  Widget _buildStatItem(String label, String value, IconData icon, [Color? color]) {
    return Column(
      children: [
        Icon(icon, size: 24, color: color ?? Colors.grey),
        const SizedBox(height: 4),
        Text(
          value,
-          style: TextStyle(
-            fontSize: 18,
-            fontWeight: FontWeight.bold,
-            color: color,
-          ),
+          style: TextStyle(fontSize: 18, fontWeight: FontWeight.bold, color: color),
        ),
        Text(label, style: TextStyle(fontSize: 12, color: Colors.grey[600])),
      ],
    );
  }

-  Widget _buildTimeItem(
-    String label,
-    DateTime time,
-    IconData icon,
-    Color color,
-  ) {
+  Widget _buildTimeItem(String label, DateTime time, IconData icon, Color color) {
    final timeStr = time.simple();
    return Padding(
      padding: const EdgeInsets.symmetric(vertical: 4),
@@ -216,10 +162,7 @@ class _ConnectionStatsPageState extends State<ConnectionStatsPage> {
        children: [
          Icon(icon, size: 16, color: color),
          UIs.width7,
-          Text(
-            '$label: ',
-            style: TextStyle(fontSize: 12, color: Colors.grey[600]),
-          ),
+          Text('$label: ', style: TextStyle(fontSize: 12, color: Colors.grey[600])),
          Text(timeStr, style: const TextStyle(fontSize: 12)),
        ],
      ),
@@ -244,13 +187,8 @@ class _ConnectionStatsPageState extends State<ConnectionStatsPage> {
          UIs.width7,
          Expanded(
            child: Text(
-              isSuccess
-                  ? '${libL10n.success} (${stat.durationMs}ms)'
-                  : stat.result.displayName,
-              style: TextStyle(
-                fontSize: 12,
-                color: isSuccess ? Colors.green : Colors.red,
-              ),
+              isSuccess ? '${libL10n.success} (${stat.durationMs}ms)' : stat.result.displayName,
+              style: TextStyle(fontSize: 12, color: isSuccess ? Colors.green : Colors.red),
              overflow: TextOverflow.ellipsis,
            ),
          ),
@@ -289,9 +227,7 @@ extension on _ConnectionStatsPageState {
                    isSuccess
                        ? '${libL10n.success} (${stat.durationMs}ms)'
                        : '${libL10n.fail}: ${stat.result.displayName}',
-                    style: TextStyle(
-                      color: isSuccess ? Colors.green : Colors.red,
-                    ),
+                    style: TextStyle(color: isSuccess ? Colors.green : Colors.red),
                  ),
                  if (!isSuccess && stat.errorMessage.isNotEmpty)
                    Text(
@@ -313,10 +249,7 @@ extension on _ConnectionStatsPageState {
            Navigator.of(context).pop();
            _showClearServerStatsDialog(stats);
          },
-          child: Text(
-            l10n.clearThisServerStats,
-            style: TextStyle(color: Colors.red),
-          ),
+          child: Text(l10n.clearThisServerStats, style: TextStyle(color: Colors.red)),
        ),
      ],
    );
--- a/lib/view/page/setting/entries/app.dart
+++ b/lib/view/page/setting/entries/app.dart
@@ -284,4 +284,122 @@ extension _App on _AppSettingsPageState {
      },
    );
  }
+
+  Widget _buildEditRawSettings() {
+    return ListTile(
+      title: const Text('(Dev) Edit raw json'),
+      trailing: const Icon(Icons.keyboard_arrow_right),
+      onTap: _editRawSettings,
+    );
+  }
+
+  Future<void> _editRawSettings() async {
+    final rawMap = Stores.setting.getAllMap(includeInternalKeys: true);
+    final map = Map<String, Object?>.from(rawMap);
+    final initialKeys = Set<String>.from(map.keys);
+    Map<String, Object?> mapForEditor = map;
+    String? encryptedKey;
+    String? passwordUsed;
+
+    Future<String?> resolvePassword() async {
+      final saved = await _setting.backupasswd.read();
+      if (saved?.isNotEmpty == true) return saved;
+      final backupPwd = await SecureStoreProps.bakPwd.read();
+      if (backupPwd?.isNotEmpty == true) return backupPwd;
+      final controller = TextEditingController();
+      try {
+        final result = await context.showRoundDialog<String>(
+          title: libL10n.pwd,
+          child: Input(
+            controller: controller,
+            label: libL10n.pwd,
+            obscureText: true,
+            onSubmitted: (_) => context.pop(controller.text.trim()),
+          ),
+          actions: [
+            TextButton(onPressed: () => context.pop(null), child: Text(libL10n.cancel)),
+            TextButton(onPressed: () => context.pop(controller.text.trim()), child: Text(libL10n.ok)),
+          ],
+        );
+        return result?.trim();
+      } finally {
+        controller.dispose();
+      }
+    }
+
+    for (final entry in map.entries) {
+      final value = entry.value;
+      if (value is String && Cryptor.isEncrypted(value)) {
+        final password = await resolvePassword();
+        if (password == null || password.isEmpty) {
+          context.showSnackBar(libL10n.cancel);
+          return;
+        }
+        try {
+          final decrypted = Cryptor.decrypt(value, password);
+          final decoded = json.decode(decrypted);
+          if (decoded is Map<String, dynamic>) {
+            mapForEditor = Map<String, Object?>.from(decoded);
+            encryptedKey = entry.key;
+            passwordUsed = password;
+            break;
+          } else {
+            context.showRoundDialog(title: libL10n.fail, child: Text(l10n.invalid));
+            return;
+          }
+        } catch (e, stack) {
+          final msg = e.toString().contains('Failed to decrypt') || e.toString().contains('incorrect password')
+              ? l10n.backupPasswordWrong
+              : '${libL10n.error}:\n$e';
+          context.showRoundDialog(title: libL10n.fail, child: Text(msg));
+          Loggers.app.warning('Decrypt raw settings failed', e, stack);
+          return;
+        }
+      }
+    }
+
+    void onSave(EditorPageRet ret) {
+      if (ret.typ != EditorPageRetType.text) {
+        context.showRoundDialog(title: libL10n.fail, child: Text(l10n.invalid));
+        return;
+      }
+      try {
+        final newSettings = json.decode(ret.val) as Map<String, dynamic>;
+        if (encryptedKey != null) {
+          final pwd = passwordUsed;
+          if (pwd == null || pwd.isEmpty) {
+            context.showRoundDialog(title: libL10n.fail, child: Text(l10n.invalid));
+            return;
+          }
+          final encrypted = Cryptor.encrypt(json.encode(newSettings), pwd);
+          Stores.setting.box.put(encryptedKey, encrypted);
+        } else {
+          Stores.setting.box.putAll(newSettings);
+          final newKeys = newSettings.keys.toSet();
+          final removedKeys = initialKeys.where((e) => !newKeys.contains(e));
+          for (final key in removedKeys) {
+            Stores.setting.box.delete(key);
+          }
+        }
+      } catch (e, trace) {
+        context.showRoundDialog(title: libL10n.error, child: Text('${l10n.save}:\n$e'));
+        Loggers.app.warning('Update json settings failed', e, trace);
+      }
+    }
+
+    /// Encode [map] to String with indent `\t`
+    final text = jsonIndentEncoder.convert(mapForEditor);
+    await EditorPage.route.go(
+      context,
+      args: EditorPageArgs(
+        text: text,
+        lang: ProgLang.json,
+        title: libL10n.setting,
+        onSave: onSave,
+        closeAfterSave: SettingStore.instance.closeAfterSave.fetch(),
+        softWrap: SettingStore.instance.editorSoftWrap.fetch(),
+        enableHighlight: SettingStore.instance.editorHighlight.fetch(),
+      ),
+    );
+  }
 }
--- a/lib/view/page/setting/entries/home_tabs.dart
+++ b/lib/view/page/setting/entries/home_tabs.dart
@@ -83,10 +83,10 @@ class _HomeTabsConfigPageState extends ConsumerState<HomeTabsConfigPage> {
      onTap: isSelected && canRemove ? () => _removeTab(tab) : null,
    );

-    return Card(
+    return Padding(
      key: ValueKey(tab.name),
-      margin: const EdgeInsets.symmetric(horizontal: 16, vertical: 4),
-      child: isSelected ? ReorderableDragStartListener(index: index, child: child) : child,
+      padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 1),
+      child: (isSelected ? ReorderableDragStartListener(index: index, child: child) : child).cardx,
    );
  }

--- a/lib/view/page/setting/entries/server.dart
+++ b/lib/view/page/setting/entries/server.dart
@@ -207,53 +207,6 @@ extension _Server on _AppSettingsPageState {
    );
  }

-  Widget _buildEditRawSettings() {
-    return ListTile(
-      title: const Text('(Dev) Edit raw json'),
-      trailing: const Icon(Icons.keyboard_arrow_right),
-      onTap: _editRawSettings,
-    );
-  }
-
-  Future<void> _editRawSettings() async {
-    final map = Stores.setting.getAllMap(includeInternalKeys: true);
-    final keys = map.keys;
-
-    void onSave(EditorPageRet ret) {
-      if (ret.typ != EditorPageRetType.text) {
-        context.showRoundDialog(title: libL10n.fail, child: Text(l10n.invalid));
-        return;
-      }
-      try {
-        final newSettings = json.decode(ret.val) as Map<String, dynamic>;
-        Stores.setting.box.putAll(newSettings);
-        final newKeys = newSettings.keys;
-        final removedKeys = keys.where((e) => !newKeys.contains(e));
-        for (final key in removedKeys) {
-          Stores.setting.box.delete(key);
-        }
-      } catch (e, trace) {
-        context.showRoundDialog(title: libL10n.error, child: Text('${l10n.save}:\n$e'));
-        Loggers.app.warning('Update json settings failed', e, trace);
-      }
-    }
-
-    /// Encode [map] to String with indent `\t`
-    final text = jsonIndentEncoder.convert(map);
-    await EditorPage.route.go(
-      context,
-      args: EditorPageArgs(
-        text: text,
-        lang: ProgLang.json,
-        title: libL10n.setting,
-        onSave: onSave,
-        closeAfterSave: SettingStore.instance.closeAfterSave.fetch(),
-        softWrap: SettingStore.instance.editorSoftWrap.fetch(),
-        enableHighlight: SettingStore.instance.editorHighlight.fetch(),
-      ),
-    );
-  }
-
  Widget _buildCpuView() {
    return ExpandTile(
      leading: const Icon(OctIcons.cpu, size: _kIconSize),
--- a/lib/view/page/storage/local.dart
+++ b/lib/view/page/storage/local.dart
@@ -4,6 +4,7 @@ import 'package:fl_lib/fl_lib.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:server_box/core/extension/context/locale.dart';
+import 'package:server_box/core/utils/host_key_helper.dart';
 import 'package:server_box/data/model/app/path_with_prefix.dart';
 import 'package:server_box/data/model/server/server_private_info.dart';
 import 'package:server_box/data/model/sftp/worker.dart';
@@ -370,6 +371,10 @@ extension _OnTapFile on _LocalFilePageState {
      return;
    }

+    if (!await ensureHostKeyAcceptedForSftp(context, spi)) {
+      return;
+    }
+
    ref.read(sftpProvider.notifier).add(SftpReq(spi, '$remotePath/$fileName', file.absolute.path, SftpReqType.upload));
    context.showSnackBar(l10n.added2List);
  }
--- a/lib/view/page/storage/sftp.dart
+++ b/lib/view/page/storage/sftp.dart
@@ -9,6 +9,7 @@ import 'package:icons_plus/icons_plus.dart';
 import 'package:server_box/core/extension/context/locale.dart';
 import 'package:server_box/core/extension/sftpfile.dart';
 import 'package:server_box/core/utils/comparator.dart';
+import 'package:server_box/core/utils/host_key_helper.dart';
 import 'package:server_box/data/model/server/server_private_info.dart';
 import 'package:server_box/data/model/sftp/browser_status.dart';
 import 'package:server_box/data/model/sftp/worker.dart';
@@ -46,7 +47,7 @@ class _SftpPageState extends ConsumerState<SftpPage> with AfterLayoutMixin {
  late final SftpBrowserStatus _status;
  late final SSHClient _client;
  final _sortOption = _SortOption().vn;
-  
+
  @override
  void initState() {
    super.initState();
@@ -286,6 +287,10 @@ extension _Actions on _SftpPageState {
      return;
    }

+    if (!await ensureHostKeyAcceptedForSftp(context, widget.args.spi)) {
+      return;
+    }
+
    final remotePath = _getRemotePath(name);
    final localPath = _getLocalPath(remotePath);
    final completer = Completer();
@@ -298,7 +303,10 @@ extension _Actions on _SftpPageState {
      context,
      args: EditorPageArgs(
        path: localPath,
-        onSave: (_) {
+        onSave: (_) async {
+          if (!await ensureHostKeyAcceptedForSftp(context, req.spi)) {
+            return;
+          }
          ref
              .read(sftpProvider.notifier)
              .add(SftpReq(req.spi, remotePath, localPath, SftpReqType.upload));
@@ -322,6 +330,10 @@ extension _Actions on _SftpPageState {
            context.pop();
            final remotePath = _getRemotePath(name);

+            if (!await ensureHostKeyAcceptedForSftp(context, widget.args.spi)) {
+              return;
+            }
+
            ref
                .read(sftpProvider.notifier)
                .add(SftpReq(widget.args.spi, remotePath, _getLocalPath(remotePath), SftpReqType.download));
@@ -652,6 +664,9 @@ extension _Actions on _SftpPageState {
        final fileName = path.split(Platform.pathSeparator).lastOrNull;
        final remotePath = '$remoteDir/$fileName';
        Loggers.app.info('SFTP upload local: $path, remote: $remotePath');
+        if (!await ensureHostKeyAcceptedForSftp(context, widget.args.spi)) {
+          return;
+        }
        ref
            .read(sftpProvider.notifier)
            .add(SftpReq(widget.args.spi, remotePath, path, SftpReqType.upload));